Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Add support for dynamic ConfigMapName and SecretName #77

Closed
hasueki opened this issue Apr 21, 2020 · 1 comment
Closed

Add support for dynamic ConfigMapName and SecretName #77

hasueki opened this issue Apr 21, 2020 · 1 comment
Assignees
@ryota-sakamoto
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.2

Comments

@hasueki
Copy link

hasueki commented Apr 21, 2020

Looking at..

argocd-notifications/shared/settings/informers.go

Lines 14 to 15 in 9b5e2b5

ConfigMapName = "argocd-notifications-cm"
SecretName = "argocd-notifications-secret"

.. it seems like specifying a custom ConfigMap or Secret name is not currently supported.

In some cases, it will be favorable to have the ability to reference a different set of ConfigMaps or Secrets. My use case working with kustomize, it will not be able to support namePrefix/nameSuffix feature in kustomizations.
@alexmt alexmt added the enhancement New feature or request label May 6, 2020
@andyfeller
Copy link
Contributor

This is essential for being able to support a helm chart where this can change from release to release like those in https://github.com/argoproj/argo-helm

@alexmt alexmt added this to the v1.1 milestone Jan 20, 2021
@alexmt alexmt added the good first issue Good for newcomers label Jan 28, 2021
@alexmt alexmt modified the milestones: v1.1, v1.2 Apr 8, 2021
@alexmt alexmt mentioned this issue Apr 23, 2021
Closed
@ryota-sakamoto ryota-sakamoto self-assigned this May 12, 2021
@ryota-sakamoto ryota-sakamoto mentioned this issue May 13, 2021
Merged
@hendrikmaus hendrikmaus mentioned this issue Dec 20, 2021
Merged
5 tasks
mbevc1 added a commit to argoproj/argo-helm that referenced this issue Dec 20, 2021
@hendrikmaus @mbevc1
feat(argocd-notifications): Support new notification controller featu…
0ce72e3 
…res from argoproj-labs/argocd-notifications#77 (#1066)

* Support setting secret name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Support setting configmap name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Use the fullname template for secret name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Use the fullname template for configmap name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Bump chart version 1.6.1 -> 1.7.0

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Update changelog

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Update README

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

Co-authored-by: Marko Bevc <marko@scalefactory.com>
terrych0u pushed a commit to terrych0u/argo-helm that referenced this issue Dec 23, 2021
@hendrikmaus @mbevc1 @terrych0u
feat(argocd-notifications): Support new notification controller featu…
e0aafeb 
…res from argoproj-labs/argocd-notifications#77 (argoproj#1066)

* Support setting secret name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Support setting configmap name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Use the fullname template for secret name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Use the fullname template for configmap name

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Bump chart version 1.6.1 -> 1.7.0

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Update changelog

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

* Update README

Signed-off-by: Hendrik Maus <aidentailor@gmail.com>

Co-authored-by: Marko Bevc <marko@scalefactory.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryota-sakamoto ryota-sakamoto

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

feat: support using multiple configmaps/secrets alexmt/argocd-notifications
4 participants
@alexmt @andyfeller @ryota-sakamoto @hasueki