This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
fix: update cached informer object instead of reloading app to avoid duplicated notifications #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Argo CD notifications might send the same notification twice or don't send notification due to stale data in the application informer. First attempt to fix it was to reload updated app before sending notification but this approach is not effective.
This PR implements an alternative approach: after patching application annotations controller immidatelly updates informer cache using application returned by patch request.