support mattermost integration #212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 49.91% 50.20% +0.29%
==========================================
Files 33 34 +1
Lines 1675 1723 +48
==========================================
+ Hits 836 865 +29
- Misses 671 683 +12
- Partials 168 175 +7
Continue to review full report at Codecov.
|
ryota-sakamoto
force-pushed
the
support-masttermost
branch
2 times, most recently
from
cf8f71e
to
e39d1fd
Compare
Signed-off-by: Ryota Sakamoto <sakamo.ryota+github@gmail.com>
Signed-off-by: Ryota Sakamoto <sakamo.ryota+github@gmail.com>
ryota-sakamoto
force-pushed
the
support-masttermost
branch
2 times, most recently
from
d7ef7dd
to
37faa04
Compare
Signed-off-by: Ryota Sakamoto <sakamo.ryota+github@gmail.com>
ryota-sakamoto
force-pushed
the
support-masttermost
branch
from
37faa04
to
75ad588
Compare
| httputil "github.com/argoproj-labs/argocd-notifications/pkg/util/http" | ||
| ) | ||
|
|
||
| type MattermostNotification struct { |
There was a problem hiding this comment.
I was under impression that we can just re-use Slack notification and templates but looks like not every field is supported.
I see attachments in documentation but no blocks, users etc https://docs.mattermost.com/developer/message-attachments.html#attachment-options
@ryota-sakamoto can you please confirm that I understand it correctly?
There was a problem hiding this comment.
Basically mattermost and slack are similar but not really compatible, right?
There was a problem hiding this comment.
@alexmt
yes. I cannot find it out that block is supported.
I guess it is only similar for attachments.
https://mattermost.atlassian.net/browse/MM-26729
Signed-off-by: Ryota Sakamoto sakamo.ryota+github@gmail.com
refs: #176
I don't use mattermost/mattermost-server model/client4.go, because it is too large to use library.