Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

feat: support loading commit metadata #87

Merged
merged 1 commit into from
May 10, 2020

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 10, 2020

Closes #43
Closes #30

PR adds function repo.GetCommitMetadata to templates/triggers that returns commit metadata.

  • implementation
  • documentation
  • tests

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #87 into master will decrease coverage by 1.46%.
The diff coverage is 26.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   53.98%   52.52%   -1.47%     
==========================================
  Files          25       25              
  Lines        1343     1388      +45     
==========================================
+ Hits          725      729       +4     
- Misses        513      551      +38     
- Partials      105      108       +3     
Impacted Files Coverage Δ
cmd/tools/tools.go 33.33% <0.00%> (-3.63%) ⬇️
shared/settings/settings.go 58.90% <0.00%> (ø)
cmd/tools/context.go 15.00% <5.55%> (-4.05%) ⬇️
cmd/tools/template.go 61.60% <16.66%> (-1.13%) ⬇️
cmd/controller.go 31.45% <22.22%> (-1.60%) ⬇️
triggers/expr/repo/repo.go 41.17% <25.00%> (-11.46%) ⬇️
triggers/triggers.go 66.10% <90.00%> (ø)
triggers/expr/expr.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5ab4b...2e97a01. Read the comment docs.

@alexmt alexmt merged commit 4275eb9 into argoproj-labs:master May 10, 2020
@alexmt alexmt deleted the commit-metadata branch May 10, 2020 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit message Show author of revision
1 participant