Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add net policy rbac and remove auth from sentinel script #1383

Merged
merged 2 commits into from
May 28, 2024

Conversation

svghadi
Copy link
Collaborator

@svghadi svghadi commented May 27, 2024

What type of PR is this?

/kind bug

What does this PR do / why we need it:

Follow up PR for #1364 to fix redis issues

svghadi added 2 commits May 27, 2024 16:01

Unverified

The committer email address is not verified.
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi
Copy link
Collaborator Author

svghadi commented May 27, 2024

I have verified the HA test manually. We are good to merge it @iam-veeramalla

Copy link
Collaborator

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svghadi

@iam-veeramalla iam-veeramalla merged commit 0225dc5 into argoproj-labs:master May 28, 2024
7 checks passed
@svghadi svghadi deleted the net-policy branch May 28, 2024 05:04
@svghadi
Copy link
Collaborator Author

svghadi commented May 28, 2024

/cherry-pick release-0.10

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 28, 2024
* Add missing networkpolicy rbac for operator-manager

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Fix sentinel liveness script

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

---------

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi
Copy link
Collaborator Author

svghadi commented May 28, 2024

/cherry-pick release-0.9

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 28, 2024
* Add missing networkpolicy rbac for operator-manager

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Fix sentinel liveness script

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

---------

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi
Copy link
Collaborator Author

svghadi commented May 28, 2024

/cherry-pick release-0.8

Copy link

Cherry-pick failed with Merge error 0225dc5602f6f31bc56166ca1cfe76df2d5f4502 into temp-cherry-pick-0de095-release-0.8

svghadi added a commit that referenced this pull request Jun 4, 2024
…#1385)

* Add missing networkpolicy rbac for operator-manager



* Fix sentinel liveness script



---------

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Co-authored-by: Siddhesh Ghadi <61187612+svghadi@users.noreply.github.com>
svghadi added a commit that referenced this pull request Jun 14, 2024
…#1386)

* Add missing networkpolicy rbac for operator-manager



* Fix sentinel liveness script



---------

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Co-authored-by: Siddhesh Ghadi <61187612+svghadi@users.noreply.github.com>
@svghadi svghadi added the backport-to-redesign Changes which need to be backported to operator-redesign branch label Jun 19, 2024
@svghadi svghadi removed the backport-to-redesign Changes which need to be backported to operator-redesign branch label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants