Skip to content

Plugin not working with directory recurse enabled #685

@joaorocha-ceiia

Description

@joaorocha-ceiia

Describe the bug
While testing the plugin, when applying an argocd application to my cluster, with the directory.recurse to true, the secret placeholder doesn't get replaced by the vault plugin. When I disabled the directory.recurse to false, it immediately started working as expected. I tested with multiple version (1.11.0, 1.16.1 and 1.18.1) and every time I got the same behaviour.

To Reproduce
Steps to reproduce the behavior:

  1. Apply this example of a argocd application manifest
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: vault-poc
  namespace: argocd
  finalizers:
    - resources-finalizer.argocd.argoproj.io
spec:
  destination:
    namespace: test-vault
    server: https://kubernetes.default.svc
  project: default
  source:
    path: argocd-vault-plugin
    repoURL: https://github.com/TiagoMorais01/ArgoCD-Vault-Teste.git
    targetRevision: HEAD
    directory:
      recurse: true
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
    syncOptions:
      - Validate=true
      - CreateNamespace=true
      - PrunePropagationPolicy=foreground
      - PruneLast=true
  1. Check the value of the "mysecret" secret, applied on the "vault-poc" namespace
kubectl get secrets mysecret -n vault-poc -o jsonpath='{.data.PORT}' | base64 -d

Expected behavior
The secret gets the value of <password> instead of the actual value of the secret from the vault (e.g. 9191 or whatever value you configured on the vault)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions