feat: Support AVP installed as CMP sidecar #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkayani
commented
Jun 13, 2022
jkayani
commented
Jun 13, 2022
jkayani
commented
Jun 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 22 22
Lines 1006 1006
=======================================
Hits 780 780
Misses 142 142
Partials 84 84 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Closed
jkayani
commented
Jun 14, 2022
There was a problem hiding this comment.
Reading over https://blog.argoproj.io/breaking-changes-in-argo-cd-2-4-29e3c2ac30c9 it looks like starting with 2.4.0, environment variables set at the application manifest get the ARGOCD_ENV prefix for argod-cm ConfigMap installed plugins, not just sidecars. So I guess existing docs need to be updated, and maybe the code should accept vars with or w/o that prefix (so AVP_TYPE or ARGOCD_ENV_AVP_TYPE)
Edit: This is all true but can probably be done in the scope of a second PR, this one can just focus on the sidecar support starting at 2.4.0
Yeah, i guess we should put something in about not working with 2.4 yet. Or at least just create an issue. |
werne2j
reviewed
Jun 16, 2022
8 tasks
werne2j
approved these changes
Jun 28, 2022
|
@jkayani for cmp-sidecar/cmp-plugin.yaml it might be a good idea to append Also, for the helm plugin, it might not be necessary to require the |
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Jul 7, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Jul 7, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
14 tasks
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Jul 7, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Jul 7, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Jul 11, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
14 tasks
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Jul 12, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Jul 15, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
jskrzypek
added a commit
to jskrzypek/argocd-vault-plugin
that referenced
this pull request
Aug 24, 2022
PR argoproj-labs#352 introduced the sidecar pattern, but also renamed the prior default manifest, which was available through a reference to https://github.com/argoproj-labs/argocd-vault-plugin//manifests To get the same app, consumers would need to change any exsting references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap This commit introduces a simple proxy manifest that makes that change backwards compatible, meaning that now older references to https://github.com/argoproj-labs/argocd-vault-plugin//manifests will still resolve to the same app state as https://github.com/argoproj-labs/argocd-vault-plugin//manifests/cmp-configmap rather than just breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Argo CD has supported sidecar based CMP (config management plugin) installation for a while now as part of the V2 proposal argoproj/argo-cd#5927. This PR adds a Kustomize app and docs for using AVP this way, and mentions some caveats associated with doing so. I think it's worth having this information especially b/c it seems
argocd-cmbased CMP installation might be deprecated in the future: argoproj/argo-cd#8117.I tested this out on the Kubecon demo repo: https://github.com/jkayani/avp-demo-kubecon-2021/tree/sidecar - this should all be reproducible locally using it.
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17to ensure only the minimum is pulled in.Type of Change
Other information