Update script to handle Optional and Union input parameters #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
jeongukjae
requested review from
flaviuvadan,
sambhav and
elliotgunton
as code owners
4 tasks
jeongukjae
added
semver:patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
- Coverage 81.7% 81.4% -0.3%
=======================================
Files 54 60 +6
Lines 4208 4732 +524
Branches 889 1004 +115
=======================================
+ Hits 3439 3856 +417
- Misses 574 646 +72
- Partials 195 230 +35 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
elliotgunton
requested changes
Aug 20, 2024
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Co-authored-by: Elliot Gunton <elliotgunton@gmail.com> Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
elliotgunton
requested changes
Aug 20, 2024
Co-authored-by: Elliot Gunton <elliotgunton@gmail.com> Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
elliotgunton
approved these changes
Aug 20, 2024
sambhav
approved these changes
Aug 20, 2024
4 tasks
sambhav
added a commit
that referenced
this pull request
Sep 2, 2024
**Pull Request Checklist** - [x] ~~Fixes #<!--issue number goes here-->~~ this PR follows up on #1160 - [x] Tests added - [x] Documentation/examples added : this is refactoring. no need - [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title **Description of PR** Currently, we are checking annotated, parameter/artifact, or other types in different ways. In this PR, I added `hera._utils.type_util` module and unified them into one place. Followings can be expected: - If there's another metadata along with Parameter or Artifact, they should be ignored. (e.g. `Annotated[type, metadata1, metadata2, Parameter(...)]`, this can be happened when `Annotated`s are nested) - `Optional` parameter handling should be more precise which is added in #1160. Suggestions on function names/module names are welcome. --------- Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com> Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com> Co-authored-by: Elliot Gunton <elliotgunton@gmail.com> Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net> Co-authored-by: Alice <Alice.Purcell.39@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently,
scriptdecorator cannot handleUnionorOptionalinput parameters because of the error inissubclass, so updated it to be able to handle it as expected.original PR: #1147