Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner script env var construction #1289

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix runner script env var construction #1289

merged 2 commits into from
Dec 9, 2024

Conversation

elliotgunton
Copy link
Collaborator

  • If user set their own env var we did not keep it

@elliotgunton elliotgunton added the type:skip-changelog A change that does not require a changelog entry label Dec 9, 2024
@elliotgunton elliotgunton mentioned this pull request Dec 9, 2024
4 tasks
@elliotgunton elliotgunton force-pushed the fix-runner-script-env branch from 73d4e7a to 737e8e4 Compare December 9, 2024 10:33
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.2%. Comparing base (25ac420) to head (8e21c9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1289   +/-   ##
=====================================
  Coverage   86.2%   86.2%           
=====================================
  Files         60      60           
  Lines       4089    4091    +2     
  Branches     652     653    +1     
=====================================
+ Hits        3526    3530    +4     
+ Misses       392     391    -1     
+ Partials     171     170    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elliotgunton elliotgunton marked this pull request as ready for review December 9, 2024 10:43
* If user set their own env var we did not keep it

Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
@elliotgunton elliotgunton force-pushed the fix-runner-script-env branch from 121e8e7 to 8e21c9b Compare December 9, 2024 10:46
@sambhav sambhav merged commit 9a8f253 into main Dec 9, 2024
25 checks passed
@sambhav sambhav deleted the fix-runner-script-env branch December 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:skip-changelog A change that does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants