fix: sanitize basename param by replacing unsupported character

[missingcharacter]

Sanitize the cluster name in accordance with the below rules:

1. contain no more than 253 characters
2. contain only lowercase alphanumeric characters, '-' or '.'
3. start and end with an alphanumeric character

Closes #306

[CLAassistant]

All committers have signed the CLA.

[crenshaw-dev]

How would you feel about adding a new variable called path.basenameNormalized to mirror the changes here? #390

If we go the direction of adding a new variable, I think it should also be documented (along with the cluster generator variable if you have some extra time 😄 ).

@jgwest just pinging with this thought: if we were to introduce some more sophisticated templating tool (e.g. expr), this would be a use case.

[thecubed]

Hi @missingcharacter !
Per our discussion earlier, here's some suggestions for the documentation.

This does seem to me like it might be useful for this project to switch to using a template generator that allows filters so one could write something like {{ basename | replace(".","_") }} akin to jinja2 or Go templates.

ApplicationSets appears to use https://github.com/valyala/fasttemplate (https://github.com/argoproj-labs/applicationset/blob/master/pkg/utils/util.go#L16) which doesn't support functions or filters, though.

That might be a task for someone else to take on at a later point though.

[missingcharacter]

Thanks @crenshaw-dev

[crenshaw-dev]

@jgwest can you take a look?

[missingcharacter]

@jgwest am I missing something for workflows to be approved?

[wtam2018]

please resolve conflicts @missingcharacter

[missingcharacter]

@wtam2018 I did, could you please approve the workflows?

Also, I ran my changes on my repo and they seem good https://github.com/missingcharacter/applicationset/runs/4668321217?check_suite_focus=true

[wtam2018]

LGTM
Thanks @missingcharacter

[missingcharacter]

Thanks @wtam2018 🙇🏽‍♂️