Add a read lock before getting cache settings

Signed-off-by: jannfis <jann@mistrust.net>
argoproj · Jul 6, 2022 · 2df1fc9 · 2df1fc9
1 parent 2aa1ce8
commit 2df1fc9
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/controller/cache/cache.go b/controller/cache/cache.go
@@ -400,7 +400,9 @@ func (c *liveStateCache) getCluster(server string) (clustercache.ClusterCache, e
 		clustercache.SetPopulateResourceInfoHandler(func(un *unstructured.Unstructured, isRoot bool) (interface{}, bool) {
 			res := &ResourceInfo{}
 			populateNodeInfo(un, res)
+			c.lock.RLock()
 			cacheSettings := c.cacheSettings
+			c.lock.RUnlock()
 			res.Health, _ = health.GetResourceHealth(un, cacheSettings.clusterSettings.ResourceHealthOverride)
 
 			appName := c.resourceTracking.GetAppName(un, cacheSettings.appInstanceLabelKey, cacheSettings.trackingMethod)