fix: parsed url is not exposed (#11816) (#11916)

alexef · web-flow · commit 2f8da71a1b6d · 2023-01-10T10:32:46.000-05:00
* fix: parsed url is not exposed (#11816) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * subtler fix, thanks @woehrl01 Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
diff --git a/ui/src/app/shared/components/urls.ts b/ui/src/app/shared/components/urls.ts
@@ -26,10 +26,10 @@ export function repoUrl(url: string): string {
 }
 
 export function revisionUrl(url: string, revision: string, forPath: boolean): string {
+    let parsed;
     try {
-        const parsed = GitUrlParse(url);
+        parsed = GitUrlParse(url);
     } catch {
-        // URL Parsing failed
         return null;
     }
     let urlSubPath = isSHA(revision) ? 'commit' : 'tree';

Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,10 @@ export function repoUrl(url: string): string {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`export function revisionUrl(url: string, revision: string, forPath: boolean): string {`
	`29`	`+ let parsed;`
`29`	`30`	`try {`
`30`		`- const parsed = GitUrlParse(url);`
	`31`	`+ parsed = GitUrlParse(url);`
`31`	`32`	`} catch {`
`32`		`- // URL Parsing failed`
`33`	`33`	`return null;`
`34`	`34`	`}`
`35`	`35`	`let urlSubPath = isSHA(revision) ? 'commit' : 'tree';`