2.6 RC1 - 'URL parsing failed' error when opening application sourced from OCI registry (ECR)

[RomanBats]

Describe the bug

I am using the latest nightly build (quay.io/argoproj/argocd@sha256:3e3890cd3614fff9d86db4facd99349cad0241fee7f974fefdd97fdca8c13ef2). Same happens with v2.6.0-rc1.

All my applications from the ECR OCI registry fail to open with an error "URL parsing failed".
It seems to me that it expects to have a protocol in the repoURL, because if I use - "repoURL: 1234567890.dkr.ecr.us-west-1.amazonaws.com" - the UI crashes. When I add "oci://" or "https://" - the UI works but, of course, the application is in an unknown state due to the "unsupported protocol scheme "oci"".

To Reproduce

Use OCI registry without protocol in the URI

Expected behavior

Either allow adding "oci://" prefix to the repoURL or support URLs without a protocol

Screenshots

Version

{
    "Version": "v2.6.0+43c928e",
    "BuildDate": "2022-12-21T19:47:17Z",
    "GitCommit": "43c928e2e5f474f8e78f66f73cd0ee2bf91a0cd1",
    "GitTreeState": "clean",
    "GoVersion": "go1.18.9",
    "Compiler": "gc",
    "Platform": "linux/arm64",
    "KustomizeVersion": "v4.5.7 2022-08-02T16:35:54Z",
    "HelmVersion": "v3.10.3+g835b733",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.19.1"
}

[alexef]

I'm also affected by this. I believe it was introduced in cd171bf will now try to figure it out

[ejennings95]

+1

Running version:

{
    "Version": "v2.6.0+566d50f",
    "BuildDate": "2022-12-22T18:52:05Z",
    "GitCommit": "566d50f6336e38579239694d8c1649236b5672cc",
    "GitTreeState": "clean",
    "GoVersion": "go1.18.9",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v4.5.7 2022-08-02T16:35:54Z",
    "HelmVersion": "v3.10.3+g835b733",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.19.1"
}

Have either of you used a work around until this is fixed? Currently i have re-deployed v2.5.5 to get around it.

[RomanBats]

@ejennings95, nope, had to roll back it as well.
Waiting for the fix to be merged.

[alexef]

Re-opening this as reported by @RomanBats: #11819 (comment)

the problem is now that on the git path (no exception raised) the variable is not visible outside the try except.