Skip to content

Commit

Permalink
Fix issue where argocd-server logged credentials in plain text during…
Browse files Browse the repository at this point in the history
… repo add (issue #653)
  • Loading branch information
jessesuen committed Sep 27, 2018
1 parent e163177 commit 316fcc6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ func (a *ArgoCDServer) newGRPCServer() *grpc.Server {
sensitiveMethods := map[string]bool{
"/session.SessionService/Create": true,
"/account.AccountService/UpdatePassword": true,
"/repository.RepositoryService/Create": true,
"/repository.RepositoryService/Update": true,
}
// NOTE: notice we do not configure the gRPC server here with TLS (e.g. grpc.Creds(creds))
// This is because TLS handshaking occurs in cmux handling
Expand Down

0 comments on commit 316fcc6

Please sign in to comment.