Use annotations with special characters

[sambonbonne]

Hello,

I did not find my answer in the documentation or in any issue, please redirect me if I can find it anywhere.

In an ApplicationSet template, I see we can use annotations from cluster secret with the cluster generator, which is great.

Now, I have an annotation with dot and slashed, like app.project.com/overlay: "overlay-name". How to use it in a template, for example:

spec:
  source:
    repoURL: '…'
    path: 'manifests/overlays/{{metadata.annotations["app.project.com/overlay"]}}'

I tried multiple syntaxes, each do not work:

• metadata.annotations["app.project.com/overlay"]
• metadata.annotations[\'app.project.com/overlay\'] (ArgoCD really did not like this one)
• metadata.annoations."app.project.com/overlay"

Some my questions are:

• is it possible?
• if yes, how and can it be documented for everyone? (I would be happy to make a PR for this after reading the contribution guidelines of course)

Thanks in advance for any help!

[crenshaw-dev]

@sambonbonne the current templating logic is super simplistic:

https://github.com/argoproj/argo-cd/blob/master/applicationset/generators/cluster.go#L141-L143

I think you could simply use metadata.annoations.app.project.com/overlay. Under the hood, the template "key" is a simple string, so fasttemplate should interpret that whole string as one "thing" and replace it with the annotation value.

In 2.5, accessing parameters as go structures will be possible, so folks will end up using something like {{ index .metadata.annotations "app.project.com/overlay" }}. For fasttemplate (the default and, in <=2.4 the only, option), {{ metadata.annoations.app.project.com/overlay }} is the way to go.

I'd welcome a PR! A quick note about how this will work with go templating would also be appreciated, if you have time. :-)

[sambonbonne]

Thanks @crenshaw-dev! I didn't know it was that simple.

I don't know much about go templating so IDK if I'll be able to write a note about it but I'll try to do something :)

Thanks again!