-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArgoCD history tab shows latest values in all recent releases #13006
Comments
I think this is the main culprit here. People should really not do that, imho. But I agree that the values of the time at installation should be recorded in the history. I suspect (but haven't validated) that Argo CD takes the default values.yaml stored in that specific version of the Chart to be recorded in the history, instead of copying them to the history.
This is expected when you don't update the chart's version. I mean, even if you would have the previously used values in the history, to what would you want to roll back? To the same version of the chart? The previous contents of this chart don't exist in the repository anymore, so a rollback isn't possible. For a rollback to work, the previous source must also exist. This might work if you had only updated the values, but there would be no guarantee that some template or other asset in the chart hasn't also changed. |
@jannfis Shouldn't we update the chart version only if the template has changed? If i'm only updating a label or config value or any other existing parameter, then updating chart version seems like an overkill. Best way to implement this is to use multiple sources (chart and values from separate repos) but ArgoCD doesn't support history/rollback with multiple sources yet, so I have to keep the values.yaml in the chart itself. |
Do you have any updates on this issue? In my situation, even when the chart version is changed, ArgoCD fails to capture the changes in the History at times. This is a critical issue because missing certain deployment history can lead to confusion and make it difficult to pass deployment audits. ArgoCD: 2.7.8 |
@Chandan-SS We resolved this issue by moving to a git repository for keeping our helm charts. With this, ArgoCD syncs the changes for each new commit instead of the chart version. |
#13006) (#21161) * fix(ISSUE-13006): ArgoCD history tab shows latest values in all recent releases Signed-off-by: Guy Saar <guysaar8@gmail.com> * chore: added org to USER.md Signed-off-by: Guy Saar <guysaar8@gmail.com> chore: added org to USER.md Signed-off-by: Guy Saar <guysaar8@gmail.com> * chore: update USER.md based on PR review Signed-off-by: Guy Saar <guysaar8@gmail.com> chore: added newline to USER.md Signed-off-by: Guy Saar <guysaar8@gmail.com> --------- Signed-off-by: Guy Saar <guysaar8@gmail.com>
The history page shows the latest values in all the releases instead of the ones that were applied after doing a hard-refresh then sync using the same Helm Chart version from a helm repo. All entries in the page display the same chart params.
This bug can be reproduced by following the following steps:
Needless to say, the rollback too isn't working.
I'm using ArgoCD app v2.6.3 and a sample of my application manifest is provided here:
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
name: payoutmerchantsvc-dev
namespace: argocd
spec:
project: default
source:
repoURL: <JFROG_HELM_REPO_URL>
chart: payoutmerchantsvc-dev
targetRevision: 1.0.1005
helm:
releaseName: payoutmerchantsvc-dev
destination:
server: "https://kubernetes.default.svc"
namespace: payoutmerchantsvc
There's another issue where this bug was mentioned #2848, event though it was closed after a bug fix #3082 I'm still facing it even after upgrading the app version to 2.6.3.
The text was updated successfully, but these errors were encountered: