Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error view instead of blank page in UI #1375

Closed
alexmt opened this issue Apr 4, 2019 · 3 comments · Fixed by #1726
Closed

Error view instead of blank page in UI #1375

alexmt opened this issue Apr 4, 2019 · 3 comments · Fixed by #1726
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.1

Comments

@alexmt
Copy link
Collaborator

alexmt commented Apr 4, 2019

Now any JS error crashes UI and user is seeing an empty screen. Instead, UI should show view with an explanation of what happened and instructions to file a bug. Instructions should include stack trace, UI version and link to github create issue. Preferrably link should include parameters to prepopulate bug in github ui.
@alexmt alexmt added enhancement New feature or request UI labels Apr 4, 2019
@alexmt
Copy link
Collaborator Author

alexmt commented Apr 4, 2019

This can be implemented with help of error-boundaries react feature.

@stale
Copy link

stale bot commented Jun 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 3, 2019
@alexmt alexmt removed the wontfix This will not be worked on label Jun 3, 2019
@mateimicu
Copy link

This sounds nice, we just his a UI problem and can't seem to figure out what the problem is.

@alexec alexec added the good first issue Good for newcomers label Jun 10, 2019
@AdityaGupta1 AdityaGupta1 mentioned this issue Jun 10, 2019
Merged
alexec pushed a commit that referenced this issue Jun 11, 2019
@AdityaGupta1 @alexec
Issue #1375 - Error view instead of blank page in UI (#1726)
e57fa0c
@alexec alexec added this to the v1.1 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Issue #1375 - Error view instead of blank page in UI
3 participants
@alexmt @alexec @mateimicu