-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for weighted resource hooks: helm.sh/hook-weight
#1396
Comments
Reference on helm hook weights: When we implement this, we need to additionally honor helm weights |
annotations:
"argoproj.io/hook-weight": "-5" |
@jessesuen I've implemented weight hooks, but I don't think they actually solve your problem 😠 . It does move us towards better Helm support mind you. You want waves of roll out. I'm going to speak to @dthomson25 about this. |
@alexec , replied in PR |
Closing this issue and replacing. |
Reopening because I don't agree |
I think we keep this open for Helm hook support. |
helm.sh/hook-weight
There is a need to perform a phased rollout of multiple deployments where deployment B needs to be deployed only after deployment B is fully ready.
Typically this use case is solved by defining an init container in deployment B, which queries its dependency (deployment A) to be up. However, there are some scenarios where init containers are unable to solve the problem.
For example, one scenario is that deployment B should not start until deployment A is running with same version of deployment B. An init container performing a version check would not help here because deployment A may be running with multiple replicas, and could potentially be returning a mix of versions, when deployment A is performing a rolling update.
Depended on by #355.
The text was updated successfully, but these errors were encountered: