Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for weighted resource hooks: helm.sh/hook-weight #1396

Closed
jessesuen opened this issue Apr 6, 2019 · 7 comments
Closed

Support for weighted resource hooks: helm.sh/hook-weight #1396

jessesuen opened this issue Apr 6, 2019 · 7 comments
Assignees
Milestone

Comments

@jessesuen
Copy link
Member

jessesuen commented Apr 6, 2019

There is a need to perform a phased rollout of multiple deployments where deployment B needs to be deployed only after deployment B is fully ready.

Typically this use case is solved by defining an init container in deployment B, which queries its dependency (deployment A) to be up. However, there are some scenarios where init containers are unable to solve the problem.

For example, one scenario is that deployment B should not start until deployment A is running with same version of deployment B. An init container performing a version check would not help here because deployment A may be running with multiple replicas, and could potentially be returning a mix of versions, when deployment A is performing a rolling update.

Depended on by #355.

@jessesuen jessesuen added the enhancement New feature or request label Apr 6, 2019
@jessesuen
Copy link
Member Author

Reference on helm hook weights:
https://github.com/helm/helm/blob/master/docs/charts_hooks.md#writing-a-hook

When we implement this, we need to additionally honor helm weights

@alexec alexec added this to the v1.1 milestone Apr 24, 2019
@alexec
Copy link
Contributor

alexec commented Apr 29, 2019

  annotations:
    "argoproj.io/hook-weight": "-5"

alexec added a commit that referenced this issue Apr 29, 2019
@alexec alexec self-assigned this Apr 30, 2019
@alexec
Copy link
Contributor

alexec commented Apr 30, 2019

@jessesuen I've implemented weight hooks, but I don't think they actually solve your problem 😠 . It does move us towards better Helm support mind you.

You want waves of roll out. I'm going to speak to @dthomson25 about this.

@alexmt
Copy link
Collaborator

alexmt commented Apr 30, 2019

@alexec , replied in PR

@alexec alexec mentioned this issue Apr 30, 2019
@alexec
Copy link
Contributor

alexec commented Apr 30, 2019

Closing this issue and replacing.

@alexec alexec closed this as completed Apr 30, 2019
@jessesuen
Copy link
Member Author

Reopening because I don't agree argoproj.io/sync-wave is the right syntax, and I think it's important to be consistent in concept and implementation with helm hook-weights, especially since we plan to map the helm-hook weights to this feature

@alexec
Copy link
Contributor

alexec commented Jun 1, 2019

I think we keep this open for Helm hook support.

@alexec alexec modified the milestones: v1.1, v1.2 Jun 1, 2019
@alexec alexec closed this as completed Jun 1, 2019
@alexec alexec modified the milestones: v1.2, v1.3 Jun 1, 2019
@alexec alexec reopened this Jun 11, 2019
@alexec alexec removed their assignment Jun 14, 2019
@alexec alexec added the helm label Jun 14, 2019
@alexec alexec added this to the v1.3 milestone Jun 14, 2019
@alexec alexec removed enhancement New feature or request labels Jun 14, 2019
@alexec alexec changed the title Support for weighted resource hooks Support for weighted resource hooks: helm.sh/hook-weight Jul 26, 2019
alexec added a commit to alexec/argo-cd that referenced this issue Jul 26, 2019
@alexec alexec self-assigned this Jul 30, 2019
@alexec alexec closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants