Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kustomize 2 parameters UI #1609

Closed
alexmt opened this issue May 13, 2019 · 4 comments
Closed

Improve Kustomize 2 parameters UI #1609

alexmt opened this issue May 13, 2019 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@alexmt
Copy link
Collaborator

alexmt commented May 13, 2019

Is your feature request related to a problem? Please describe.

The Parameters tab of Kustomize 2 apps should be as usable as Kustomize 1. With kustomize 1 UI user can quickly see the images and have simple UI to change image tags. With Kustomize 2 user seeing nothing in view mode, unless images are overridden. In edit mode UI only provides text input to override image.

Describe the solution you'd like
The view mode should be similar to Kustomize 1. Edit mode should allow using Kustomize 2 features ( e.g. set new name )

image

image

@alexmt alexmt added the enhancement New feature or request label May 13, 2019
@alexec
Copy link
Contributor

alexec commented May 21, 2019

I'm not sure about this. It brings a LOT of logic into the UI. It was an explicit decision to dumbly pass the images to kustomize, to keep the code simple while making sure no power was abstracted away.

I don't feel strongly about this, but I'm am worried a more complex UI creates more work for ourselves.

@alexmt
Copy link
Collaborator Author

alexmt commented May 28, 2019

Apparently there is not so much logic, just two functions: parse and format: https://github.com/argoproj/argo-cd-ui/pull/125/files#diff-15133e3112f57e4790c0b0773d329c66R14

The rest of changes are UI related. I think it worth support it because it really increases usabilty of UI for kustomize apps.

@alexmt
Copy link
Collaborator Author

alexmt commented May 28, 2019

Implemented

@alexmt alexmt closed this as completed May 28, 2019
@alexec alexec added this to the v1.1 milestone May 28, 2019
@alexec
Copy link
Contributor

alexec commented May 28, 2019

I've added milestone.

alexec pushed a commit to alexec/argo-cd that referenced this issue Jun 3, 2019
* Issue argoproj#1609 - Improve Kustomize 2 parameters UI

* Add unit tests for kustomize image parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants