Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI will crash when create application without destination namespace #1701

Closed
eric4545 opened this issue Jun 6, 2019 · 2 comments · Fixed by #1713
Closed

UI will crash when create application without destination namespace #1701

eric4545 opened this issue Jun 6, 2019 · 2 comments · Fixed by #1713
Labels
bug Something isn't working
Milestone

Comments

@eric4545
Copy link

eric4545 commented Jun 6, 2019

Describe the bug
Showing blank page / UI crash after login.

To Reproduce
If we cannot reproduce, we cannot fix! Steps to reproduce the behavior:

  1. Create guestbook.yaml with below content
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: guestbook
spec:
  project: default
  source:
    repoURL: https://github.com/argoproj/argocd-example-apps.git
    targetRevision: HEAD
    path: guestbook
  destination:
    server: https://kubernetes.default.svc
    # namespace: guestbook
  1. kubectl -n argocd apply -k guestbook
  2. kubectl -n argocd port-forward svc/argocd-server 8000:443
  3. login https://localhost:8000, Blank page will occur

Expected behavior
Expected applications page working properly

Screenshots
If applicable, add screenshots to help explain your problem.
image

Version

argocd: v1.0.1+5fe1447.dirty
  BuildDate: 2019-05-28T17:28:05Z
  GitCommit: 5fe1447b722716649143c63f9fc054886d5b111c
  GitTreeState: dirty
  GoVersion: go1.11.4
  Compiler: gc
  Platform: darwin/amd64
argocd-server: v1.0.1+5fe1447.dirty
  BuildDate: 2019-05-28T17:27:38Z
  GitCommit: 5fe1447b722716649143c63f9fc054886d5b111c
  GitTreeState: dirty
  GoVersion: go1.11.4
  Compiler: gc
  Platform: linux/amd64
  Ksonnet Version: 0.13.1
@eric4545 eric4545 added the bug Something isn't working label Jun 6, 2019
@alexec
Copy link
Contributor

alexec commented Jun 6, 2019

@alexmt @jessesuen would this be fixed by #1687

@alexmt
Copy link
Collaborator

alexmt commented Jun 7, 2019

@alexec #1687 won't help. It still will be possible to specify an empty string as a value and api server will drop the field during serialization to json. Sent PR with fix: #1713

alexmt pushed a commit that referenced this issue Jun 7, 2019
@alexec alexec added this to the v1.2 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants