Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Versions are not sorted in the documentation. #20289

Closed
jaehanbyun opened this issue Oct 8, 2024 · 5 comments · Fixed by #20322
Closed

Release Versions are not sorted in the documentation. #20289

jaehanbyun opened this issue Oct 8, 2024 · 5 comments · Fixed by #20322
Labels
component:docs enhancement New feature or request

Comments

@jaehanbyun
Copy link
Contributor

Summary

The current documentation site for Argo CD displays release versions in an unsorted manner.

스크린샷 2024-10-08 오후 10 09 43

Motivation

Proper sorting will improve user experience by providing a clear structure for accessing different releases.

Proposal

Update the logic responsible for displaying release versions on the documentation site to ensure they are sorted in ascending numerical order.
@jaehanbyun jaehanbyun added the enhancement New feature or request label Oct 8, 2024
@linghaoSu
Copy link
Member

It seems this issue has been fixed in this PR: https://github.com/argoproj/argo-cd/pull/20181/files.

@jaehanbyun
Copy link
Contributor Author

It seems this issue has been fixed in this PR: https://github.com/argoproj/argo-cd/pull/20181/files.

I checked it, Thanks!

@linghaoSu
Copy link
Member

Oops! This fix only works when the browser's language is set to English.

@linghaoSu
Copy link
Member

https://github.com/argoproj/argo-cd/pull/20181/files#diff-9dded3ea5cb0de3f54e11ec05ce0490920e01776e604a2f8c25d8f65845c55a7R84

This line hardcodes version, but in other languages, MkDocs uses i18n, so it won't sort properly.

@jaehanbyun
Copy link
Contributor Author

@linghaoSu As you mentioned, when I change the browser language settings, the sorting does not work properly. May I work on addressing this issue?

image

@jaehanbyun jaehanbyun mentioned this issue Oct 10, 2024
Merged
14 tasks
agaudreault pushed a commit that referenced this issue Oct 17, 2024
@jaehanbyun
fix(docs): ensure version dropdown sorts correctly regardless of brow…
d1ef0f8 
…ser language #20289 (#20322)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
@jaehanbyun jaehanbyun mentioned this issue Oct 25, 2024
Closed
6 tasks
adriananeci pushed a commit to adriananeci/argo-cd that referenced this issue Dec 4, 2024
@jaehanbyun @adriananeci
fix(docs): ensure version dropdown sorts correctly regardless of brow…
a15ca69 
…ser language argoproj#20289 (argoproj#20322)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:docs enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@reggie-k @linghaoSu @jaehanbyun