-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI commands through HTTP ingress using --grpc-web no longer work in v1.5.3 #3541
Labels
bug/priority:high
Should be fixed in the next patch release
bug/severity:criticial
A critical bug in ArgoCD, possibly resulting in data loss or severe degraded overall functionality
bug
Something isn't working
regression
Bug is a regression, should be handled with high priority
Comments
jannfis
added
bug/priority:high
Should be fixed in the next patch release
bug/severity:criticial
A critical bug in ArgoCD, possibly resulting in data loss or severe degraded overall functionality
regression
Bug is a regression, should be handled with high priority
labels
May 4, 2020
@mayzhang2000 I suspect this was introduced by either #3475 or #3503 - can you please take a look? |
5 tasks
Hello! I updated argocd to v1.5.4, download new cli tool and I'm still having this issue. $ ~/Downloads/argocd-darwin-amd64 login <server addr>:80 --plaintext --grpc-web --username <username> --password <password> --insecure
FATA[0000] rpc error: code = Unimplemented desc = In addition on v.1.5.2 it doesn't work too :-( |
I just tried argocd login localhost:8080 --plaintext --grpc-web --username admin --password xxx
'admin' logged in successfully
Context 'localhost:8080' updated
argocd version
argocd: v1.5.4+36bade7
BuildDate: 2020-05-05T19:02:56Z
GitCommit: 36bade7a2d7b69d1c0b0c4d41191f792a847d61c
GitTreeState: clean
GoVersion: go1.14.1
Compiler: gc
Platform: darwin/amd64
argocd-server: v99.99.99+unknown
BuildDate: 1970-01-01T00:00:00Z
GitCommit:
GitTreeState:
GoVersion: go1.13.10
Compiler: gc
Platform: darwin/amd64
Ksonnet Version: v0.13.1
Kustomize Version: Version: {Version:3.2.1 GitCommit:d89b448c745937f0cf1936162f26a5aac688f840 BuildDate:2019-10-03T19:25:14+01:00 GoOs:darwin GoArch:amd64}
Helm Version: version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}
Kubectl Version: v1.17.4 |
No issues here anymore after upgrading to v1.5.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug/priority:high
Should be fixed in the next patch release
bug/severity:criticial
A critical bug in ArgoCD, possibly resulting in data loss or severe degraded overall functionality
bug
Something isn't working
regression
Bug is a regression, should be handled with high priority
Describe the bug
Starting with v1.5.3, the CLI no longer communicates with the server (either v1.5.2 or v.1.5.3) using an ingress with the
HTTP
backend protocol (no SSL passthrough) in combination with the--grpc-web
argument. ThisUnimplemented
error pops up for every server interaction (in this case fromargocd --grpc-web version
):This used to work with v1.5.2, so that you could have a single Ingress terminate TLS and use it for both CLI and UI.
This must have something to do with the recent root path changes.
To Reproduce
--grpc-web
option.Expected behavior
The CLI connects to the server correctly without
Unimplemented
errors.Version
CLI v1.5.3 fails to get the server version due to this error. This is when I use CLI v1.5.2:
The text was updated successfully, but these errors were encountered: