Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI commands through HTTP ingress using --grpc-web no longer work in v1.5.3 #3541

Closed
sfynx opened this issue May 4, 2020 · 4 comments · Fixed by #3544
Closed

CLI commands through HTTP ingress using --grpc-web no longer work in v1.5.3 #3541

sfynx opened this issue May 4, 2020 · 4 comments · Fixed by #3544
Assignees
Labels
bug/priority:high Should be fixed in the next patch release bug/severity:criticial A critical bug in ArgoCD, possibly resulting in data loss or severe degraded overall functionality bug Something isn't working regression Bug is a regression, should be handled with high priority

Comments

@sfynx
Copy link
Contributor

sfynx commented May 4, 2020

Describe the bug

Starting with v1.5.3, the CLI no longer communicates with the server (either v1.5.2 or v.1.5.3) using an ingress with the HTTP backend protocol (no SSL passthrough) in combination with the --grpc-web argument. This Unimplemented error pops up for every server interaction (in this case from argocd --grpc-web version):

FATA[0000] rpc error: code = Unimplemented desc = unknown service /version.VersionService

This used to work with v1.5.2, so that you could have a single Ingress terminate TLS and use it for both CLI and UI.

This must have something to do with the recent root path changes.

To Reproduce

  1. Install CLI v1.5.3.
  2. Create single HTTP ingress without SSL passthrough
  3. Try to use the CLI with the --grpc-web option.

Expected behavior

The CLI connects to the server correctly without Unimplemented errors.

Version

CLI v1.5.3 fails to get the server version due to this error. This is when I use CLI v1.5.2:

argocd: v1.5.2+c2c19f4
  BuildDate: 2020-04-15T16:43:41Z
  GitCommit: c2c19f42ad78ed7a6fb70e86aed117be484feb50
  GitTreeState: clean
  GoVersion: go1.14
  Compiler: gc
  Platform: darwin/amd64
argocd-server: v1.5.3+095c5d6
  BuildDate: 2020-05-02T04:21:47Z
  GitCommit: 095c5d616b1cb39f87e8f7a54cabea2643e1c99a
  GitTreeState: clean
  GoVersion: go1.14.1
  Compiler: gc
  Platform: linux/amd64
  Ksonnet Version: v0.13.1
  Kustomize Version: {Version:kustomize/v3.5.4 GitCommit:3af514fa9f85430f0c1557c4a0291e62112ab026 BuildDate:2020-01-11T03:12:59Z GoOs:linux GoArch:amd64}
  Helm Version: version.BuildInfo{Version:"v3.2.0", GitCommit:"e11b7ce3b12db2941e90399e874513fbd24bcb71", GitTreeState:"clean", GoVersion:"go1.13.10"}
  Kubectl Version: v1.14.0
@sfynx sfynx added the bug Something isn't working label May 4, 2020
@jannfis jannfis added bug/priority:high Should be fixed in the next patch release bug/severity:criticial A critical bug in ArgoCD, possibly resulting in data loss or severe degraded overall functionality regression Bug is a regression, should be handled with high priority labels May 4, 2020
@jannfis
Copy link
Member

jannfis commented May 4, 2020

@mayzhang2000 I suspect this was introduced by either #3475 or #3503 - can you please take a look?

@tkukushkin
Copy link

tkukushkin commented May 6, 2020

Hello! I updated argocd to v1.5.4, download new cli tool and I'm still having this issue.

$ ~/Downloads/argocd-darwin-amd64 login <server addr>:80 --plaintext --grpc-web --username <username> --password <password> --insecure
FATA[0000] rpc error: code = Unimplemented desc =

In addition on v.1.5.2 it doesn't work too :-(

@mayzhang2000
Copy link
Contributor

I just tried

argocd login localhost:8080 --plaintext --grpc-web --username admin --password xxx
'admin' logged in successfully
Context 'localhost:8080' updated

argocd version
argocd: v1.5.4+36bade7
  BuildDate: 2020-05-05T19:02:56Z
  GitCommit: 36bade7a2d7b69d1c0b0c4d41191f792a847d61c
  GitTreeState: clean
  GoVersion: go1.14.1
  Compiler: gc
  Platform: darwin/amd64
argocd-server: v99.99.99+unknown
  BuildDate: 1970-01-01T00:00:00Z
  GitCommit: 
  GitTreeState: 
  GoVersion: go1.13.10
  Compiler: gc
  Platform: darwin/amd64
  Ksonnet Version: v0.13.1
  Kustomize Version: Version: {Version:3.2.1 GitCommit:d89b448c745937f0cf1936162f26a5aac688f840 BuildDate:2019-10-03T19:25:14+01:00 GoOs:darwin GoArch:amd64}
  Helm Version: version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}
  Kubectl Version: v1.17.4

@sfynx
Copy link
Contributor Author

sfynx commented May 6, 2020

No issues here anymore after upgrading to v1.5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/priority:high Should be fixed in the next patch release bug/severity:criticial A critical bug in ArgoCD, possibly resulting in data loss or severe degraded overall functionality bug Something isn't working regression Bug is a regression, should be handled with high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants