fix: Set root path

[mayzhang2000]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Optional. My organization is added to USERS.md.
• I've signed the CLA and my build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #3475 into master will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3475      +/-   ##
==========================================
- Coverage   43.22%   43.09%   -0.14%     
==========================================
  Files         180      180              
  Lines       20090    20127      +37     
  Branches      273      237      -36     
==========================================
- Hits         8684     8673      -11     
- Misses      10407    10462      +55     
+ Partials      999      992       -7     

Impacted Files	Coverage Δ
cmd/argocd/commands/login.go	0.00% <0.00%> (ø)
cmd/argocd/commands/relogin.go	0.00% <0.00%> (ø)
cmd/argocd/commands/root.go	4.65% <0.00%> (-0.12%)	⬇️
server/server.go	56.58% <0.00%> (-1.01%)	⬇️
server/project/project.go	59.66% <0.00%> (-1.74%)	⬇️
ui/src/app/applications/components/utils.tsx	49.83% <0.00%> (ø)
ui/src/app/shared/services/projects-service.ts	19.71% <0.00%> (ø)
server/application/application.go	28.31% <0.00%> (+0.20%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7660e40...9e504fc. Read the comment docs.

[alexmt]

This works! Just want to suggest a slightly different approach to avoid coupling code related to golang bug workaround:

• Create handler which adds root prefix to any handler:

func withRootPath(handler http.Handler, root string) http.Handler {
	// get rid of slashes
	root = strings.TrimRight(strings.TrimLeft(root, "/"), "/")

	mux := http.NewServeMux()
	mux.Handle("/"+root+"/", http.StripPrefix("/"+root, handler))
	return mux
}

• use it to add root path to argocd server here:

	if rootPath != "" {
		httpS.Handler = withRootPath(httpS.Handler, rootPath)
		if httpsS != nil {
			httpsS.Handler = withRootPath(httpsS.Handler, rootPath)
		}
	}

[alexmt]

The --rootpath flag is supposed to change both server-side and client-side behavior. So if it is specified we need to add root path on server-side and change UI basehref as well.

I think we should just check if rootPath if not empty and change baseHRef to the same value. If for some reason user has specified conflictingbaseHRef value then I suggest to print warning and override it with rootPath

[alexmt]

Argo CD CLI has an option to talk to the server using grpc web protocol (e.g. argocd app list --grpc-web).

The grpc web requests should use root path, so we need to add CLI flag to specify path. Can you please add --grpc-web-root-path flag. If flag is set then CLI should send grpc web requests with the specified path. Request URL is constructed here:

argo-cd/pkg/apiclient/grpcproxy.go

Line 58 in 4bd8173

req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("%s://%s%s", schema, c.ServerAddr, fullMethodName), bytes.NewReader(toFrame(msg)))

For convenience we should assume that user wants to use grpc web if either --grpc-web or --grpc-web-root-path is set

[alexmt]

@mayzhang2000 ,

@gpaul brought up a good point in #3483 (comment)

argocd login --grpc-web-root-path /argocd should be stored in argocd config so user does not have to repeat that CLI flag in every argocd command. Can you please implement that change. Config is updated in CLI login command implementation:

argo-cd/cmd/argocd/commands/login.go

Lines 112 to 116 in 73590e1

	localCfg.UpsertServer(localconfig.Server{
	Server: server,
	PlainText: globalClientOpts.PlainText,
	Insecure: globalClientOpts.Insecure,
	GRPCWeb: globalClientOpts.GRPCWeb,

[mayzhang2000]

fixes #3319