Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running in Autosync, syncing takes forever. Proposal to autosync selective only out of sync items #3877

Closed
peterbosalliandercom opened this issue Jun 30, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@peterbosalliandercom
Copy link

Summary

We need to speed up syncing, sometimes it takes hours before syncing is ready. We found that a 'normal' sync applies to all items, also the synced items. This takes much time. When we do a selective sync for all 'out-of-sync' items it is ready in seconds. We like to have an option in the automatic sync to filter all out of sync items. The same as in the UI like here:
image

Motivation

We cannot use the autosync right now because the apps stay in syncing state.

Proposal

extend the autosync with an option to use selective sync: 'out-of-sync'

@peterbosalliandercom peterbosalliandercom added the enhancement New feature or request label Jun 30, 2020
@ghostsquad
Copy link

I'm curious to know why the syncing takes so long. What does CPU/Memory usage of ArgoCD look like during a sync?

@peterbosalliandercom
Copy link
Author

We have a lot of resources sub helm charts etc

@peterbosalliandercom
Copy link
Author

We use argo to deploy multiple namespaces with resources in one time.

@kshamajain99
Copy link
Contributor

Looking into this.

@Smirl
Copy link

Smirl commented Jan 27, 2021

Hey @kshamajain99, Any update on this? Any guidance on an open source PR? Our syncs are taking hours to complete now when we only add/update/remove a couple of objects per commit. In our case we have a chart that deploys tenant namespaces, RBAC, resource quotas, etc. as mentioned in #4521

@ghostsquad
Copy link

It would nice to have some more debug information on this, like what is it doing that causes it to take so long? (this is a message to the maintainers). Would debug level logging be enough to get this information?

@kshamajain99
Copy link
Contributor

@Smirl I am currently working on this issue, you can expect an PR soon in a day or two.

alexmt pushed a commit that referenced this issue Jan 29, 2021
* selective sync

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@alexmt
Copy link
Collaborator

alexmt commented Jan 29, 2021

Implemented. Thank you @kshamajain99 !

@alexmt alexmt closed this as completed Jan 29, 2021
@peterbosalliandercom
Copy link
Author

@kshamajain99 Is this option influencing the post sync hooks?

@Smirl
Copy link

Smirl commented Feb 16, 2021

Do you have a timeline/milestone for when this will be release? I don't see it in the 1.9 milestone. It would save hours of each sync for us when it is out.

@kshamajain99
Copy link
Contributor

@Smirl This issue is in 1.9 milestone. It will be released in a week or two.

shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this issue Apr 15, 2021
* selective sync

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants