Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI only links to the last OwnerReference in the list #3910

Closed
alexvanboxel opened this issue Jul 7, 2020 · 1 comment · Fixed by #11715
Closed

UI only links to the last OwnerReference in the list #3910

alexvanboxel opened this issue Jul 7, 2020 · 1 comment · Fixed by #11715
Labels
bug Something isn't working

Comments

@alexvanboxel
Copy link

Describe the bug

The UI only shows a link to the last OwnerReference of a resource in the OwnerReferences list. You would expect that it links to all of the parents.

To Reproduce

Apply the following file: kubectl apply -f owner-a.yaml

apiVersion: v1
data:
  foo: "bar"
kind: ConfigMap
metadata:
  name: owner-a

Apply the following file: kubectl apply -f owner-b.yaml

apiVersion: v1
data:
  foo: "bar"
kind: ConfigMap
metadata:
  name: owner-a

Now get the UID's of the applied files by using

kubectl get cm owner-a -o=yaml
kubectl get cm owner-b -o=yaml

Fill the UID in the following file, so the UID is correct for each resource (AAAAA for owner-a, BBBBB for owner-b):

apiVersion: v1
data:
  foo: "bar"
kind: ConfigMap
metadata:
  name: child
  ownerReferences:
    - apiVersion: v1
      kind: owner-a
      name: privacy
      uid: AAAAA
    - apiVersion: v1
      kind: ConfigMap
      name: owner-b
      uid: BBBBB

If you now go to the UI you will see that only the last owner is linked too.

Screen Shot 2020-07-07 at 11 25 47 AM

If you flip owner-a and -b the UI will flip to the other parent (the last one)

Screen Shot 2020-07-07 at 11 26 41 AM

Expected behavior

You would expect the UI links to both OwnerReferences.

Screen Shot 2020-07-07 at 11 40 59 AM

Version

v1.5.8+47f43f9
@alexvanboxel alexvanboxel added the bug Something isn't working label Jul 7, 2020
@peterwhitesell
Copy link

I would like to see this fixed as well. For us it would be very handy to be able to navigate our way to dependent resources from different owner references for different audiences

crenshaw-dev added a commit that referenced this issue Jan 19, 2023
* fix: populate parentRefs correctly with multiple owners

It previously simply wrote to key 0, instead of appending all owners

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* test multiple resource owners

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
emirot pushed a commit to emirot/argo-cd that referenced this issue Jan 27, 2023
… (argoproj#11715)

* fix: populate parentRefs correctly with multiple owners

It previously simply wrote to key 0, instead of appending all owners

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* test multiple resource owners

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this issue Mar 14, 2023
… (argoproj#11715)

* fix: populate parentRefs correctly with multiple owners

It previously simply wrote to key 0, instead of appending all owners

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* test multiple resource owners

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants