Unable to update Helm chart dependencies if there is any Helm OCI repository configured

[lsolovey]

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in argocd slack channel.

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

Argo CD fails to update Helm chart dependencies if there is any Helm OCI repository configured in the system.
This OCI repository may not be even used, it just needs to be added to Argo CD to cause the issue.

It looks like Argo CD is trying to execute helm repo add ... command for every registered Helm repository before running helm dependency update. If there is Helm OCI repository registered in Argo CD, helm repo add ... fails for such OCI repo.

time="2021-03-24T15:19:21-04:00" level=fatal msg="rpc error: code = InvalidArgument desc = application spec is invalid: InvalidSpecError: Unable to generate manifests in application-chart: rpc error: code = Unknown desc = ``helm repo add --username ****** --password ****** test-helm-oci-repo myregistry.azurecr.io/helm`` failed exit status 1: Error: could not find protocol handler for:

As far as I understand helm repo add ... doesn't work with Helm OCI repos, so probably Helm OCI repos should be excluded from helm repo add ... step.

To Reproduce

Please refer to the sample project: https://github.com/lsolovey/argocd-helm-oci

1. Add any Helm OCI repository. It’s not going to be used by our application, it just needs to be added to Argo CD:

argocd repo add myregistry.azurecr.io/helm --type helm --name test-helm-oci-repo --enable-oci --username <username> --password <password>

2. Create new Application pointing to the Helm chart which has some dependencies declared in Chart.yaml

argocd app create sample-app --dest-namespace argocd --dest-server https://kubernetes.default.svc --repo https://github.com/lsolovey/argocd-helm-oci.git --path application-chart --sync-policy auto

Application creation fails with the error mentioned above.

Expected behavior

Application should be created successfully.

Version

argocd: v1.8.7+eb3d1fb
  BuildDate: 2021-03-03T07:16:29Z
  GitCommit: eb3d1fb84b9b77cdffd70b14c4f949f1c64a9416
  GitTreeState: clean
  GoVersion: go1.14.12
  Compiler: gc
  Platform: windows/amd64
argocd-server: v1.8.7+eb3d1fb
  BuildDate: 2021-03-03T07:13:34Z
  GitCommit: eb3d1fb84b9b77cdffd70b14c4f949f1c64a9416
  GitTreeState: clean
  GoVersion: go1.14.12
  Compiler: gc
  Platform: linux/amd64
  Ksonnet Version: v0.13.1
  Kustomize Version: v3.8.1 2020-07-16T00:58:46Z
  Helm Version: v3.4.1+gc4e7485
  Kubectl Version: v1.17.8
  Jsonnet Version: v0.17.0

[AustinSmart]

I've just run into the same issue. Indeed OCI Helm repositories do not support helm repo add

This may be the source of the issue:

argo-cd/util/helm/helm.go

Line 70 in 6cc8ab0

_, err := h.cmd.RepoAdd(repo.Name, repo.Repo, repo.Creds)

argo-cd/reposerver/repository/repository.go

Line 494 in 6cc8ab0

err = h.DependencyBuild()

argo-cd/reposerver/repository/repository.go

Line 613 in 6cc8ab0

err = h.DependencyBuild()

[lsolovey]

Thanks @AustinSmart for fixing this. I installed v2.0.0-rc2 and verified the fix.

[m-yosefpor]

I'm facing a similar issue with argocd v2.1-rc3 (however when using OCI charts as dependencies)

rpc error: code = Unknown desc = Manifest generation error (cached): `helm repo add registry.private.snappcloud.io oci://registry.private.snappcloud.io/emq` failed exit status 1: Error: looks like "oci://registry.private.snappcloud.io/emq" is not a valid chart repository or cannot be reached: tag explicitly required

argocd version:

argocd-server: v2.1.0-rc3+5700faf
  BuildDate: 2021-08-11T19:44:44Z
  GitCommit: 5700faf0d17dacad93c5fe96edd42fb6dd1ae7b1
  GitTreeState: clean
  GoVersion: go1.16.5
  Compiler: gc
  Platform: linux/amd64
  Ksonnet Version: v0.13.1
  Kustomize Version: v4.2.0 2021-06-30T22:49:26Z
  Helm Version: v3.6.0+g7f2df64
  Kubectl Version: v0.21.0
  Jsonnet Version: v0.17.0