Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename server.crt and server.key to tls.crt and tls.key #617

Closed
jessesuen opened this issue Sep 20, 2018 · 2 comments
Closed

Rename server.crt and server.key to tls.crt and tls.key #617

jessesuen opened this issue Sep 20, 2018 · 2 comments

Comments

@jessesuen
Copy link
Member

jessesuen commented Sep 20, 2018

We should update the argocd-secret such that it uses the standard tls.crt and tls.key keys in the secret instead of its current keys: server.crt and server.key. This will make the argocd-secret compatible with things like Ingress and Cert Manager. Note that this will require the user to perform a manual step of copying or renaming the keys before the upgrade and needs to be documented as a breaking change in the release notes.

@jessesuen
Copy link
Member Author

jessesuen commented Sep 20, 2018

I confirmed that cert-manager will update an existing secret with just those two keys and not replace the entire secret:
cert-manager/cert-manager#221

@mrbobfrog
Copy link

I confirmed that cert-manager will update an existing secret with just those two keys and not replace the entire secret:
cert-manager/cert-manager#221

@jessesuen We may want to add that tidbit to the argocd docs to save the next person the trouble of tracking release notes to issues and comments... I can make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants