Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax ingress/service health check to accept non-empty ingress list #1053

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Relax ingress/service health check to accept non-empty ingress list #1053

merged 1 commit into from
Jan 23, 2019

Conversation

jessesuen
Copy link
Member

Resolves #997

@jessesuen jessesuen requested a review from alexmt January 19, 2019 07:52
@codecov-io
Copy link

codecov-io commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #1053 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   36.74%   36.73%   -0.01%     
==========================================
  Files          52       52              
  Lines        7495     7494       -1     
==========================================
- Hits         2754     2753       -1     
  Misses       4332     4332              
  Partials      409      409
Impacted Files Coverage Δ
util/health/health.go 56.73% <100%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838d770...5cd77e5. Read the comment docs.

@jessesuen jessesuen merged commit ccbf803 into argoproj:master Jan 23, 2019
@jessesuen jessesuen deleted the 997-ingress-svc-health branch January 23, 2019 00:40
jessesuen added a commit that referenced this pull request Feb 15, 2019
@jessesuen
Relax ingress/service health check to accept non-empty ingress list (#…
5af774d 
…1053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessesuen @codecov-io @alexmt