feat: inversion selection support for the resource filter on sync and wait app commands (#10548) #10893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10893 +/- ##
==========================================
+ Coverage 47.28% 47.30% +0.01%
==========================================
Files 245 245
Lines 41607 41661 +54
==========================================
+ Hits 19674 19706 +32
- Misses 19948 19970 +22
Partials 1985 1985 ☔ View full report in Codecov by Sentry. |
maheshbaliga
force-pushed
the
add-negation-to-resource-filter
branch
5 times, most recently
from
7e3f564 to
bbe1445
Compare
maheshbaliga
force-pushed
the
add-negation-to-resource-filter
branch
2 times, most recently
from
63fa83b to
9f6cfe9
Compare
|
Hi @crenshaw-dev, can you please review this PR and let me know if any changes are required. |
maheshbaliga
force-pushed
the
add-negation-to-resource-filter
branch
from
9f6cfe9 to
80352cc
Compare
crenshaw-dev
requested changes
Dec 1, 2022
maheshbaliga
force-pushed
the
add-negation-to-resource-filter
branch
2 times, most recently
from
56ede9f to
f1ef581
Compare
crenshaw-dev
approved these changes
Jan 5, 2023
|
@maheshbaliga can you resolve conflicts? |
… wait app commands Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io>
auto-merge was automatically disabled
January 5, 2023 16:26
Head branch was pushed to by a user without write access
maheshbaliga
force-pushed
the
add-negation-to-resource-filter
branch
from
f1ef581 to
0571d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10548
Implements the --resource flag enhancement.
Sync and Wait commands to manage applications can now be filtered with negative selection of the resources. Matching app resources that satisfy at-least one of the resource filter condition will be selected.
Examples of the inversion filter are:
argocd app wait my-app --resource '!apps:Deployment:my-service'
argocd app sync my-app --resource '!*:Deployment:*'
Checklist: