Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #1098

Merged
merged 8 commits into from
Feb 11, 2019
Merged

Update CONTRIBUTING.md #1098

merged 8 commits into from
Feb 11, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 7, 2019

Issue #1095

@codecov-io
Copy link

codecov-io commented Feb 7, 2019 •
edited
Loading

Codecov Report

Merging #1098 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   36.95%   36.95%           
=======================================
  Files          53       53           
  Lines        7683     7683           
=======================================
  Hits         2839     2839           
  Misses       4423     4423           
  Partials      421      421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49e8da...e7939b1. Read the comment docs.

alexmt
alexmt reviewed Feb 7, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
alexmt
alexmt approved these changes Feb 7, 2019
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please take a look at couple minor comments before merging.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@alexec
Copy link
Contributor Author

alexec commented Feb 8, 2019

I'll keep this open for a bit as I add more details.

@alexec
Copy link
Contributor Author

alexec commented Feb 11, 2019

@jessesuen / @alexmt - could you please merge this PR? I do not have permission.

@alexec alexec merged commit eeed50e into argoproj:master Feb 11, 2019
@alexec alexec deleted the issue-1095 branch February 11, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexec @codecov-io @alexmt @jessesuen