-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action menu: sort items, show in resource details page #11008
Conversation
So that the same action shows up in the same position every time the drop down is opened Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Codecov ReportBase: 45.60% // Head: 45.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11008 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 239 239
Lines 28973 28973
=======================================
Hits 13214 13214
Misses 13940 13940
Partials 1819 1819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
One small suggestion at first glance: |
@rbreeze I can do that, but I have a different idea. What if (on the details page) instead of a drop down, I generate gray rounded buttons (looking the same as sync and diff). Then we avoid one extra click to expand the drop down. the disabled ones can be rendered as disabled or not rendered at all. What I'm afraid is only if the list becomes too large, on smaller screens it may look weird, overlap with the Resource name on the left. Should I give it a try? |
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌
E2E failures can't be related to changes in PR (as they passed before merge with master). @rbreeze can you have another look? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: emirot <emirot.nolan@gmail.com>
I notice that every time I open the burger menu, the resource customization actions show up in random order. This sorts them alphabetically.
Additionally, to avoid an extra click, I'm adding the menu to the resource details page (next to SYNC and DELETE buttons).
Before
After
Checklist: