Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ui): fix incomplete drop-down resource actions #11384

Merged
merged 1 commit into from
Nov 21, 2022
Merged

bug(ui): fix incomplete drop-down resource actions #11384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/app/applications/components/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ function getActionItems(
})
.catch(() => [] as MenuItem[]);

const resourceActions = getResourceActionsMenuItems(resource, application, appContext);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbreeze shouldn't a mistake like this one be caught by the type checks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should... not sure why it didn't this time.

const resourceActions = getResourceActionsMenuItems(resource, application.metadata, appContext);

return combineLatest(
from([items]), // this resolves immediately
Expand Down