Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis-ha IPv4 only #11418

Closed
wants to merge 3 commits into from

Conversation

34fathombelow
Copy link
Member

@34fathombelow 34fathombelow commented Nov 24, 2022

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

Disabled IPv6 in HAProxy, which was causing issues with clusters that were IPv4 only or had IPv6 disabled. Dual stack clusters will continue to operate normally. Added a bind directive to allow Redis to start with IPv4/6. Sentinel bind is no longer an option since version 7.0

Note: IPv6 only clusters will not be compatible.

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@34fathombelow 34fathombelow marked this pull request as draft November 24, 2022 18:49
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 47.30% // Head: 47.30% // No change to project coverage 👍

Coverage data is based on head (9265f25) compared to base (cb467bc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11418   +/-   ##
=======================================
  Coverage   47.30%   47.30%           
=======================================
  Files         243      243           
  Lines       41524    41524           
=======================================
  Hits        19643    19643           
  Misses      19907    19907           
  Partials     1974     1974           
Impacted Files Coverage Δ
util/settings/settings.go 48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@34fathombelow
Copy link
Member Author

Closing superseded by #11862

@34fathombelow 34fathombelow deleted the redis-ha-ipv4 branch January 10, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant