Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(health): Handling SparkApplication CRD health status if dynamic allocation is enabled (#7557) #11522

Merged
merged 2 commits into from
Jan 27, 2023
Merged

fix(health): Handling SparkApplication CRD health status if dynamic allocation is enabled (#7557) #11522

merged 2 commits into from
Jan 27, 2023

Conversation

eugen-fried
Copy link
Contributor

@eugen-fried eugen-fried commented Dec 1, 2022 •
edited by crenshaw-dev
Loading

Fixes #7557
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Base: 47.41% // Head: 47.41% // No change to project coverage 👍

Coverage data is based on head (5074749) compared to base (4610bc8).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11522   +/-   ##
=======================================
  Coverage   47.41%   47.41%           
=======================================
  Files         246      246           
  Lines       41815    41815           
=======================================
  Hits        19825    19825           
  Misses      19994    19994           
  Partials     1996     1996
Impacted Files Coverage Δ
util/settings/settings.go 48.27% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eugen-fried eugen-fried force-pushed the master branch 5 times, most recently from 36c7d7e to d762e43 Compare December 7, 2022 17:10
@eugen-fried eugen-fried closed this Dec 7, 2022
@eugen-fried eugen-fried reopened this Dec 7, 2022
@crenshaw-dev crenshaw-dev changed the title Handling SparkApplication CRD health status if dynamic allocation is enabled #7557 fix(health): Handling SparkApplication CRD health status if dynamic allocation is enabled (#7557) Dec 7, 2022
@eugen-fried eugen-fried marked this pull request as draft December 8, 2022 10:40
@eugen-fried
Hadling SparkApplication CRD health status if dynamic allocation is e…
5ba519f 
…nabled

Signed-off-by: Yevgeniy Fridland <yevg.mord@gmail.com>
@eugen-fried eugen-fried marked this pull request as ready for review December 8, 2022 13:55
@pdrastil
Copy link
Member

Hi @crenshaw-dev can you merge this please?

crenshaw-dev
crenshaw-dev approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That code was a pleasure to read. Very easy to follow. Thanks @eugen-fried!

@crenshaw-dev crenshaw-dev added cherry-pick/2.6 cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 labels Jan 19, 2023
@crenshaw-dev
Copy link
Member

I plan to merge and cut a release with this next Wednesday.

@eugen-fried
Copy link
Contributor Author

Thank you!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) January 27, 2023 18:21
@crenshaw-dev crenshaw-dev disabled auto-merge January 27, 2023 18:21
@crenshaw-dev
Copy link
Member

Not sure what's up w/ CI. Running again.

Sorry for the delay. Looking to release this today.

@crenshaw-dev crenshaw-dev merged commit eaac2c6 into argoproj:master Jan 27, 2023
crenshaw-dev added a commit that referenced this pull request Jan 27, 2023
@eugen-fried @crenshaw-dev
fix(health): Handling SparkApplication CRD health status if dynamic a…
063dce4 
…llocation is enabled (#7557) (#11522)

Signed-off-by: Yevgeniy Fridland <yevg.mord@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jan 27, 2023
@eugen-fried @crenshaw-dev
fix(health): Handling SparkApplication CRD health status if dynamic a…
1925612 
…llocation is enabled (#7557) (#11522)

Signed-off-by: Yevgeniy Fridland <yevg.mord@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jan 27, 2023
@eugen-fried @crenshaw-dev
fix(health): Handling SparkApplication CRD health status if dynamic a…
45c089b 
…llocation is enabled (#7557) (#11522)

Signed-off-by: Yevgeniy Fridland <yevg.mord@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jan 27, 2023
@eugen-fried @crenshaw-dev
fix(health): Handling SparkApplication CRD health status if dynamic a…
a05a450 
…llocation is enabled (#7557) (#11522)

Signed-off-by: Yevgeniy Fridland <yevg.mord@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Member

Cherry-picked onto release-2.6 for 2.6.0-rc6, release-2.5 for 2.5.9, release-2.4 for 2.4.21, and release-2.3 for 2.3.15

emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@eugen-fried @crenshaw-dev @emirot
fix(health): Handling SparkApplication CRD health status if dynamic a…
9c5eb9a 
…llocation is enabled (argoproj#7557) (argoproj#11522)

Signed-off-by: Yevgeniy Fridland <yevg.mord@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
@Reamer Reamer mentioned this pull request Jan 31, 2023
Merged
10 tasks
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@eugen-fried @crenshaw-dev @schakrad
fix(health): Handling SparkApplication CRD health status if dynamic a…
61f160c 
…llocation is enabled (argoproj#7557) (argoproj#11522)

Signed-off-by: Yevgeniy Fridland <yevg.mord@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdrastil pdrastil pdrastil approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 cherry-pick/2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sparkoperator.k8s.io/SparkApplication health check does not support dynamicAllocation
3 participants
@eugen-fried @pdrastil @crenshaw-dev