-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #110 - Rollback ignores parameter overrides #117
Conversation
As discussed, we will create a new rollback RPC endpoint which has numeric identifiers of the previous app history. Rollback will be done using this interface. The CLI usage will work like:
|
@jessesuen as we agreed rollback functionality is now available via separate API call. PTAL |
server/application/application.go
Outdated
} | ||
} | ||
if deploymentInfo == nil { | ||
return nil, fmt.Errorf("application %s does not have deployment with id %v", rollbackReq.Name, rollbackReq.Id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of fmt.Errorf, can we use status.Errorf(codes.InvalidArgument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. thank you!
I will add |
Contributes to: ibm-saas-platform/workitems#5181 Signed-off-by: David Gay <david.gay@ibm.com>
Contributes to: ibm-saas-platform/workitems#5181 Signed-off-by: David Gay <david.gay@ibm.com>
No description provided.