Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #110 - Rollback ignores parameter overrides #117

Merged
merged 3 commits into from
Apr 24, 2018

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Apr 23, 2018

No description provided.

@alexmt alexmt requested review from merenbach and jessesuen April 23, 2018 19:19
@jessesuen
Copy link
Member

As discussed, we will create a new rollback RPC endpoint which has numeric identifiers of the previous app history. Rollback will be done using this interface. The CLI usage will work like:

argocd app rollback guestbook 34

@alexmt
Copy link
Collaborator Author

alexmt commented Apr 24, 2018

@jessesuen as we agreed rollback functionality is now available via separate API call. PTAL

}
}
if deploymentInfo == nil {
return nil, fmt.Errorf("application %s does not have deployment with id %v", rollbackReq.Name, rollbackReq.Id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of fmt.Errorf, can we use status.Errorf(codes.InvalidArgument

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. thank you!

@jessesuen
Copy link
Member

I will add argo app history guestbook and argo app rollback guestbook <id> after your changes

@alexmt alexmt merged commit 63dafa0 into argoproj:master Apr 24, 2018
@alexmt alexmt deleted the sync-param-override branch April 24, 2018 20:34
alexec pushed a commit that referenced this pull request Apr 24, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…oyed (#117)
sujeilyfonseca pushed a commit to sujeilyfonseca/argo-cd that referenced this pull request Mar 5, 2024
Contributes to: ibm-saas-platform/workitems#5181

Signed-off-by: David Gay <david.gay@ibm.com>
sujeilyfonseca pushed a commit to sujeilyfonseca/argo-cd that referenced this pull request Jun 7, 2024
Contributes to: ibm-saas-platform/workitems#5181

Signed-off-by: David Gay <david.gay@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants