Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better error messages #11738

Merged
merged 2 commits into from
Jan 9, 2023
Merged

chore: better error messages #11738

merged 2 commits into from
Jan 9, 2023

Conversation

crenshaw-dev
Copy link
Member

No description provided.

@crenshaw-dev
chore: better error messages
e5130af 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
ashutosh16
ashutosh16 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@ashutosh16 ashutosh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 16, 2022 •
edited
Loading

Codecov Report

Base: 47.00% // Head: 47.30% // Increases project coverage by +0.29% 🎉

Coverage data is based on head (ffbaba2) compared to base (a89e489).
Patch coverage: 7.14% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11738      +/-   ##
==========================================
+ Coverage   47.00%   47.30%   +0.29%     
==========================================
  Files         243      243              
  Lines       40457    41528    +1071     
==========================================
+ Hits        19017    19644     +627     
- Misses      19525    19910     +385     
- Partials     1915     1974      +59
Impacted Files Coverage Δ
controller/appcontroller.go 51.88% <0.00%> (-0.46%) ⬇️
util/db/cluster.go 59.49% <25.00%> (ø)
controller/state.go 67.76% <0.00%> (-4.12%) ⬇️
.../apis/application/v1alpha1/applicationset_types.go 29.26% <0.00%> (-3.17%) ⬇️
...cationset/controllers/applicationset_controller.go 61.45% <0.00%> (-2.52%) ⬇️
reposerver/cache/cache.go 60.00% <0.00%> (-2.07%) ⬇️
util/git/client.go 49.65% <0.00%> (-1.28%) ⬇️
controller/sync.go 56.69% <0.00%> (-0.98%) ⬇️
pkg/apis/application/v1alpha1/repository_types.go 71.03% <0.00%> (-0.29%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ishitasequeira
ishitasequeira reviewed Dec 17, 2022
View reviewed changes
util/db/cluster.go Outdated Show resolved Hide resolved
crenshaw-dev
crenshaw-dev commented Dec 20, 2022
View reviewed changes
util/db/cluster.go Outdated Show resolved Hide resolved
@crenshaw-dev
Update util/db/cluster.go
ffbaba2 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev merged commit 1cc154f into argoproj:master Jan 9, 2023
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@crenshaw-dev @emirot
chore: better error messages (argoproj#11738)
d653a2c 
* chore: better error messages

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Update util/db/cluster.go

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@crenshaw-dev @schakrad
chore: better error messages (argoproj#11738)
a45a7a7 
* chore: better error messages

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Update util/db/cluster.go

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
@crenshaw-dev crenshaw-dev deleted the error-messages branch July 20, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira left review comments

@ashutosh16 ashutosh16 ashutosh16 approved these changes

@wanghong230 wanghong230 wanghong230 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crenshaw-dev @wanghong230 @ashutosh16 @ishitasequeira