refactor: Make fsnotify event more readable. #11836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 47.44% // Head: 47.44% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11836 +/- ##
=======================================
Coverage 47.44% 47.44%
=======================================
Files 245 245
Lines 41690 41690
=======================================
Hits 19778 19778
Misses 19925 19925
Partials 1987 1987 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yanggangtony
changed the title
Signed-off-by: yanggang <gang.yang@daocloud.io>
|
This pr have been a time for review. |
jannfis
approved these changes
Jan 25, 2023
jannfis
changed the title
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io> Signed-off-by: yanggang <gang.yang@daocloud.io> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io> Signed-off-by: yanggang <gang.yang@daocloud.io> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanggang gang.yang@daocloud.io
As fsnotify v1.6.0 mentioned.
We can replace
with
will be more readable and maintenance.