Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reused common.DefaultRepoServerAddr #11842

Merged
merged 1 commit into from
Jan 25, 2023
Merged

chore: Reused common.DefaultRepoServerAddr #11842

merged 1 commit into from
Jan 25, 2023

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Dec 28, 2022

Signed-off-by: yanggang gang.yang@daocloud.io

Make const parm DefaultRepoServerAddr reused by others.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 47.44% // Head: 47.44% // No change to project coverage 👍

Coverage data is based on head (525ed01) compared to base (6069ded).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11842   +/-   ##
=======================================
  Coverage   47.44%   47.44%           
=======================================
  Files         245      245           
  Lines       41690    41690           
=======================================
  Hits        19778    19778           
  Misses      19925    19925           
  Partials     1987     1987           
Impacted Files Coverage Δ
cmd/argocd/commands/admin/notifications.go 0.00% <0.00%> (ø)
util/settings/settings.go 48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yanggangtony
Copy link
Contributor Author

This pr have been a time for review.
Would you have time to review it?
@crenshaw-dev @jannfis @rbreeze

Signed-off-by: yanggang <gang.yang@daocloud.io>
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@jannfis jannfis merged commit 3da1eaa into argoproj:master Jan 25, 2023
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io>

Signed-off-by: yanggang <gang.yang@daocloud.io>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io>

Signed-off-by: yanggang <gang.yang@daocloud.io>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants