Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: repo command give more hints. #11849

Merged
merged 1 commit into from
Jan 26, 2023
Merged

chore: repo command give more hints. #11849

merged 1 commit into from
Jan 26, 2023

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

Give more hints by cobra command help info.

@codecov
Copy link

codecov bot commented Dec 29, 2022 •
edited
Loading

Codecov Report

Base: 47.41% // Head: 47.41% // No change to project coverage 👍

Coverage data is based on head (443ec6c) compared to base (b2a6387).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11849   +/-   ##
=======================================
  Coverage   47.41%   47.41%           
=======================================
  Files         246      246           
  Lines       41815    41815           
=======================================
  Hits        19825    19825           
  Misses      19994    19994           
  Partials     1996     1996
Impacted Files Coverage Δ
cmd/argocd/commands/repo.go 0.00% <0.00%> (ø)
util/settings/settings.go 48.27% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yanggangtony
Copy link
Contributor Author

This pr have been a time for review.
Would you have time to review it?
@crenshaw-dev @jannfis @rbreeze

jannfis
jannfis approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis
Copy link
Member

jannfis commented Jan 25, 2023

Oh sorry, I have seen that one of the CI test has failed (the codegen one). The generated CLI docs differ, because you changed help text for command line arguments.

Please run make clidocsgen and commit/push the changes, so that CI will pass.

repo command give more hints.
443ec6c 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@yanggangtony
Copy link
Contributor Author

@jannfis
thanks for quick review..
rebased it.

@yanggangtony
Copy link
Contributor Author

image

a ci error shows up.
may have no business with the pr.

@jannfis jannfis enabled auto-merge (squash) January 26, 2023 01:52
@jannfis jannfis merged commit 61f6530 into argoproj:master Jan 26, 2023
@jsoref jsoref mentioned this pull request Jan 26, 2023
Open
10 tasks
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@emirot
chore: repo command give more hints. (argoproj#11849)
4d3ffb2 
Signed-off-by: yanggang <gang.yang@daocloud.io>

Signed-off-by: yanggang <gang.yang@daocloud.io>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@schakrad
chore: repo command give more hints. (argoproj#11849)
ade8e28 
Signed-off-by: yanggang <gang.yang@daocloud.io>

Signed-off-by: yanggang <gang.yang@daocloud.io>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanggangtony @jannfis