-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 adding helm repo password refresh #11857
Conversation
Codecov ReportBase: 47.32% // Head: 47.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11857 +/- ##
==========================================
- Coverage 47.32% 47.28% -0.04%
==========================================
Files 245 245
Lines 41545 41582 +37
==========================================
+ Hits 19661 19664 +3
- Misses 19903 19936 +33
- Partials 1981 1982 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
util/helm/client.go
Outdated
@@ -164,6 +167,19 @@ func (c *nativeHelmChart) ExtractChart(chart string, version string, passCredent | |||
defer func() { _ = os.RemoveAll(tempDest) }() | |||
|
|||
if c.enableOci { | |||
// check to see if new password needs to be generated | |||
if c.creds.CredsRefreshCmd != "" && c.isExpiredCredentials() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although this is how the argo-image-updater
does credential refresh, I'm not a big fan of arbitrary code execution, and it would also require the repo-server
to have those binaries available on the filesystem.
97557cc
to
be1355d
Compare
@igaskin Hi, I really need this feature. Is there a way I can help/Is there a standard workaround you know of? |
@blakepettersson this was actually something I expected the repo-server would do by itself, as I understand that by supporting this, other OCI registries' custom login methods might follow. Therefore, it might make sense to take advantage of external-secrets already implementing this, so argo components can avoid implementing it. However, having it implemented in some components but not in others, where it is equally needed, is not consistent and might be a bit confusing |
Would be great to have this feature. Maybe one can streamline this so that u can just pass the type of registry and can easily contribute new authentication mechanism for other registries, so that someone would need an special authenticatihion for gke or something like this he can easily contribute |
useful for ECR OCI helm repositories which require credential refresh after 12 hours
✅ Closes: #8097
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: