Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] feat(concurrent): enabling concurrent reconciles for the applications… #11881

Closed

Conversation

rumstead
Copy link
Member

@rumstead rumstead commented Jan 4, 2023

Closes #10952

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 47.32% // Head: 47.33% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1a41275) compared to base (8f0ef8d).
Patch coverage: 76.92% of modified lines in pull request are covered.

❗ Current head 1a41275 differs from pull request most recent head 383f7d5. Consider uploading reports for the commit 383f7d5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11881   +/-   ##
=======================================
  Coverage   47.32%   47.33%           
=======================================
  Files         245      246    +1     
  Lines       41545    41558   +13     
=======================================
+ Hits        19661    19671   +10     
- Misses      19903    19906    +3     
  Partials     1981     1981           
Impacted Files Coverage Δ
...cationset/controllers/applicationset_controller.go 61.26% <0.00%> (-0.20%) ⬇️
applicationset/utils/keylock.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…et controller

Signed-off-by: rumstead <rjumstead@gmail.com>
@rumstead rumstead force-pushed the feat/enable-concur-reconciles-appset branch from 1a41275 to ae1a9ee Compare January 4, 2023 18:26
@@ -54,6 +58,7 @@ func (a *argoCDService) GetFiles(ctx context.Context, repoURL string, revision s
return nil, err
}

defer a.keyLock.Lock(repoURL)()
Copy link
Member Author

@rumstead rumstead Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locking on the repo URL doesnt help too much if you have a monorepo where the config files for your app live. It would make more sense to checkout and lock based on something like <app set name>/<repo URL>/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize ApplicationSet Reconciliation Loop
1 participant