Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency on github.com/pkg/errors #11886

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

Fish-pro
Copy link
Contributor

@Fish-pro Fish-pro commented Jan 5, 2023

Signed-off-by: Fish-pro zechun.chen@daocloud.io

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 47.30% // Head: 47.29% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (e822655) compared to base (8917077).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head e822655 differs from pull request most recent head 73b2af2. Consider uploading reports for the commit 73b2af2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11886      +/-   ##
==========================================
- Coverage   47.30%   47.29%   -0.02%     
==========================================
  Files         245      245              
  Lines       41670    41669       -1     
==========================================
- Hits        19712    19706       -6     
- Misses      19972    19978       +6     
+ Partials     1986     1985       -1     
Impacted Files Coverage Δ
server/server.go 54.03% <ø> (ø)
util/kube/portforwarder.go 0.00% <0.00%> (ø)
util/kustomize/kustomize.go 72.47% <ø> (ø)
applicationset/generators/pull_request.go 46.87% <0.00%> (-3.13%) ⬇️
applicationset/generators/matrix.go 69.49% <0.00%> (-0.26%) ⬇️
server/repository/repository.go 51.50% <0.00%> (-0.13%) ⬇️
cmd/argocd/commands/admin/cluster.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Fish-pro Fish-pro force-pushed the cleanup/errors branch 2 times, most recently from e65b7df to 7fd38dd Compare January 7, 2023 04:07
@Fish-pro
Copy link
Contributor Author

Fish-pro commented Jan 7, 2023

/cc @crenshaw-dev

@Fish-pro Fish-pro force-pushed the cleanup/errors branch 3 times, most recently from 1221a06 to dfe1fb9 Compare January 16, 2023 02:08
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
@Fish-pro
Copy link
Contributor Author

Fish-pro commented Jan 18, 2023

@crenshaw-dev
The functionality that thegithub.com/pkg/errors provides is already present in golang's builtin errors,and the github repo is now read-only.
So it is suggested to remove the dependency on 'github.com/pkg/errors', please review, thanks

@crenshaw-dev crenshaw-dev merged commit 49412a1 into argoproj:master Jan 18, 2023
@crenshaw-dev crenshaw-dev changed the title fix: remove dependency on github.com/pkg/errors chore: remove dependency on github.com/pkg/errors Jan 18, 2023
@crenshaw-dev
Copy link
Member

crenshaw-dev commented Jan 18, 2023

@Fish-pro thanks! I'm going to consider this a chore until a fix unless/until a vulnerability or bug appears in github.com/pkg/errors.

emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants