fix: remove other occurrences of externalURLS #11887 #11889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Codecov ReportBase: 47.30% // Head: 47.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11889 +/- ##
=======================================
Coverage 47.30% 47.30%
=======================================
Files 245 245
Lines 41661 41661
=======================================
Hits 19706 19706
Misses 19970 19970
Partials 1985 1985 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rbreeze
approved these changes
Jan 6, 2023
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…j#11889) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…j#11889) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11887
Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: