Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redact secret data in deep links #11931

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix: redact secret data in deep links #11931

merged 1 commit into from
Jan 10, 2023

Conversation

gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Jan 10, 2023 •
edited
Loading

Signed-off-by: Soumya Ghosh Dastidar gdsoumya@gmail.com

This PR fixes deep links to redact any secret data used in the resource links.

ref: #11888 (comment)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@gdsoumya
fix: redact secret data in deep links
bb16ac5 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya requested a review from crenshaw-dev January 10, 2023 07:29
@gdsoumya gdsoumya assigned alexmt and unassigned alexmt Jan 10, 2023
@gdsoumya gdsoumya requested a review from alexmt January 10, 2023 07:29
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 47.29% // Head: 47.29% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bb16ac5) compared to base (abf6d73).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11931      +/-   ##
==========================================
- Coverage   47.29%   47.29%   -0.01%     
==========================================
  Files         245      245              
  Lines       41665    41669       +4     
==========================================
  Hits        19706    19706              
- Misses      19974    19978       +4     
  Partials     1985     1985
Impacted Files Coverage Δ
server/application/application.go 28.07% <0.00%> (-0.07%) ⬇️
util/settings/settings.go 48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

alexmt
alexmt approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit e323880 into argoproj:master Jan 10, 2023
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@gdsoumya @emirot
fix: redact secret data in deep links (argoproj#11931)
9109737 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@gdsoumya @schakrad
fix: redact secret data in deep links (argoproj#11931)
b650b3e 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

@crenshaw-dev crenshaw-dev Awaiting requested review from crenshaw-dev

Assignees
No one assigned
Labels
cherry-pick/2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdsoumya @alexmt @crenshaw-dev