fix: Explicitly set private key type for GPG key generation #11944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <jann@mistrust.net>
Codecov ReportBase: 47.29% // Head: 47.29% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11944 +/- ##
=======================================
Coverage 47.29% 47.29%
=======================================
Files 245 245
Lines 41669 41669
=======================================
Hits 19706 19706
Misses 19978 19978
Partials 1985 1985
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
No need to cherry-pick back, right? As I understand it, this can't bite us until we upgrade the base image. |
|
Exactly. This is a forward-fix :) |
crenshaw-dev
approved these changes
Jan 11, 2023
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…#11944) Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…#11944) Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
make test-localon a Fedora 37 box, the GnuPG key creation failed in the unit tests. After doing some research, it seems that recent versions of GnuPG have a bug [1] when specifying the key type to be generated asDefault, so this PR explicitly sets it to RSA. We really don't care about the long term security of the private key, as it's only used to initialize the trust db and is transient by nature.Submitting this fix before it hits us :)
Current version of GnuPG in our most recent release (v2.5.4):
Version from Fedora 37:
[1] https://dev.gnupg.org/T5444
Signed-off-by: jannfis jann@mistrust.net
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: