fix: Add namespace to sub-application link URLs (#11945)

[iandelahorne]

Fixes #11518 and #11945

• ui: Add namespace to sub-application links in list and tree view
• Add Patreon to USERS.md

Screenshots:

Tree view with sub-applications in other namespaces

List view with sub-applications in other namespaces

With "apps in other namespaces" disabled, and using argocd-example-apps/apps from HEAD, this is the behavior - the links work as before, but now the namespace (argocd) is included before the application name.

Tree view with sub-applications, "Apps in other namespaces" disabled

Signed-off-by: Ian Delahorne ian@patreon.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[iandelahorne]

👋 I'm new to submitting PRs to ArgoCD, and also not a frontend expert. This will add the namespace to the external link for all sub-applications, not just those in non-argocd namespaces.

[codecov]

Codecov Report

Base: 47.38% // Head: 47.38% // No change to project coverage 👍

Coverage data is based on head (117f117) compared to base (4a50114).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #11946   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files         245      245           
  Lines       41670    41670           
=======================================
  Hits        19745    19745           
  Misses      19937    19937           
  Partials     1988     1988           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ashutosh16]

@iandelahorne Thanks for submitting the PR, would you be able to provide the screenshot of the UI changes?

[crenshaw-dev]

Thanks for the PR @iandelahorne! Have you confirmed that the change works fine for apps-of-apps when apps-in-any-namespace is disabled?

[iandelahorne]

@ashutosh16 Sure, I added screenshots to the description

@crenshaw-dev It does indeed work well for app-of-apps when apps-in-any-namespace is disabled, I verified this on my test cluster and added a screenshot.

[alexef]

This fixes #11518

[alexef]

I see we also have appQualifiedName in utils.tsx, but that function seems to be for display purpose.

I cannot find other place where we generate the applications/ url.

I confirm the url WITH namespace also works when multiple namespaces are not enabled.

[iandelahorne]

Thanks for the review @alexef! I'm not familiar with the devleopment flow - do I need to ping someone on slack or attend a contributor's meeting for this to get reviewed and merged?

[crenshaw-dev]

@iandelahorne no need, we're just a little behind on reviews. Folks keep contributing things. 🙂

[rbreeze]

LGTM

[mikeeq]

Why it wasn't cherry-pick'ed to v2.5.8 but #12115 was? :(

[crenshaw-dev]

@mikeeq I think the other cherry-pick was actually in error. We had a code freeze for the CVE patch. I'll cherry-pick this so it goes out with 2.5.9.

[crenshaw-dev]

Cherry-picked onto release-2.5 for 2.5.9 and release-2.6 for 2.6.0-rc6.