chore: Support running dockerized toolchain using sudo

[jannfis]

Previously, when a user was not part of the docker group, they had to run the make targets for the dockerized toolchain using sudo in order to leverage Docker. This could have led to lots of fscked up permissions in the source tree.

This small fix for the toolchain adds support for properly using sudo to leverage docker, instead of relying on the user to be member of the (privileged) docker group.

User can now just run: SUDO=sudo make <target> and the Makefile will leverage sudo as appropriate. This also allows to specify to impersonate other users, e.g. by setting SUDO="sudo -u foobar" make <target>

The change also removes a lot of chmod -R 777 from the test container's Dockerfile, which were added as a result of mixed user ids accessing the same set of files. These chmod's were both slow, and insecure.

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Base: 47.29% // Head: 47.29% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4b602b5) compared to base (c31d15e).
Patch has no changes to coverable lines.

❗ Current head 4b602b5 differs from pull request most recent head 108f82b. Consider uploading reports for the commit 108f82b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11955      +/-   ##
==========================================
- Coverage   47.29%   47.29%   -0.01%     
==========================================
  Files         245      245              
  Lines       41670    41669       -1     
==========================================
- Hits        19707    19706       -1     
  Misses      19978    19978              
  Partials     1985     1985              

Impacted Files	Coverage Δ
server/repository/repository.go	51.50% <0.00%> (-0.13%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jannfis]

Maybe someone could test this on a mac, please? :)

[crenshaw-dev]

Worked fine on my Mac. Thanks!