fix: Argo CD doesn't detect the repo type when repository is scoped #11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 47.28% // Head: 47.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11959 +/- ##
==========================================
+ Coverage 47.28% 47.29% +0.01%
==========================================
Files 245 245
Lines 41669 41670 +1
==========================================
+ Hits 19702 19707 +5
+ Misses 19981 19978 -3
+ Partials 1986 1985 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
project-scoped-repo-check
branch
from
83c6a9a to
6c59b98
Compare
alexmt
added a commit
that referenced
this pull request
Jan 12, 2023
…11959) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…rgoproj#11959) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
sujeilyfonseca
pushed a commit
to sujeilyfonseca/argo-cd
that referenced
this pull request
Mar 7, 2023
…rgoproj#11959) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…rgoproj#11959) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Closes #9580
The #8558 updated repository API to verify that repo is permitted in a project before returning list of applications/application details for given repository. The check loads project directly using project informer and does not take into account project scoped repositories. This PR fixes the issue.