-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow force of basic auth for HTTP repositories #11983
feat: Allow force of basic auth for HTTP repositories #11983
Conversation
Codecov ReportBase: 47.30% // Head: 47.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11983 +/- ##
==========================================
+ Coverage 47.30% 47.44% +0.13%
==========================================
Files 245 246 +1
Lines 41670 41860 +190
==========================================
+ Hits 19712 19859 +147
- Misses 19972 20002 +30
- Partials 1986 1999 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
427cf19
to
5ffeb0d
Compare
Signed-off-by: jannfis <jann@mistrust.net>
5ffeb0d
to
91e4cb2
Compare
@crenshaw-dev @leoluz @alexmt Could I get someone of you having a look at this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @jannfis!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also update https://argo-cd.readthedocs.io/en/latest/operator-manual/declarative-setup/ and argocd-repositories.yaml with examples?
Good thinking, I'll update this PR to include some docs. Thanks! |
Cherry-picked onto release-2.6 for 2.6.0-rc7. |
* feat: Allow force of basic auth for HTTP repositories Signed-off-by: jannfis <jann@mistrust.net> * Some docs Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net>
* feat: Allow force of basic auth for HTTP repositories Signed-off-by: jannfis <jann@mistrust.net> * Some docs Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Change introduces a new boolean setting for repositories:
forceHttpBasicAuth
. If set to true, Argo CD will make the Git client send anAuthorization: Basic ...
header to the repository server, thereby bypassing any authentication scheme negotiation done by Git (or libcurl, to be precise).Closes #11914
Fixes #6289
Fixes #6362
Signed-off-by: jannfis jann@mistrust.net
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: