docs: Fixed typos, and grammar in the High Availability Docs #12021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
Parsifal-M
changed the title
Codecov ReportBase: 47.30% // Head: 47.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12021 +/- ##
=======================================
Coverage 47.30% 47.30%
=======================================
Files 245 245
Lines 41670 41670
=======================================
Hits 19712 19712
Misses 19972 19972
Partials 1986 1986 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tico24
approved these changes
Jan 18, 2023
jannfis
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Thanks for improving the docs, @Parsifal-M !
I have a couple of nits, please see below comments.
Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
jannfis
approved these changes
Jan 18, 2023
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…j#12021) * Fixed typos, and grammar Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com> * Updated Docs based on PR Feedback Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com> Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…j#12021) * Fixed typos, and grammar Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com> * Updated Docs based on PR Feedback Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com> Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Macdonald macdonald.peter90@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Hey Team!
I was reading the High Availability docs today and noticed it didn't quite "roll off the tongue" and had some grammatical mistakes that could be improved on while I read it 😄 hope this is okay?
Please LMK if I am missing something.
Thanks!